Reduce RealNumberQ and refactor #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a WMA builtin so it should not be protected. Possibly we should remove this altogether and add ExactNumberQ Rubi 5 defines RealNumberQ so this is a problem.
* Add slightly better test() annotation for the return type
* create BooleanType and use that
* Reduce use of RealNumberQ by removing it from Range[]
* Move {In,}ExactNumberQ from numbers to numerical_properties which is where
other tests appear. (it is smaller than numbers).
* add is_number() to mathics.eval.numbers
rocky
force-pushed
the
reduce-RealNumberQ-and-refactor
branch
from
687badc to
31770b2
Compare
Closed
mmatera
reviewed
Mar 22, 2023
mathics/builtin/list/constructing.py
Outdated
| "Range[imin_, imax_, di_]" | ||
|
|
||
| for arg in imin, imax, di: | ||
| if not is_number(arg): |
There was a problem hiding this comment.
Actually, what we need to check is if they are real numbers.
There was a problem hiding this comment.
Meaning Real, integer or rational
There was a problem hiding this comment.
The function was poorly (ambiguously or incorrectly) named. That has been corrected. However what it does I think is the correct thing. I compared with WMA.
There was a problem hiding this comment.
I agree. The comment was about the name of the internal function
mmatera
reviewed
Mar 22, 2023
|
There will be more PRs to remove RealNumberQ. This is just the first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #820.
As is common, the changes needed are far too great to do in one programming session. So this is the first part.