improving rules for Bessel functions with half integer indices #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I am glad to see more code being written in Mathics as opposed to Python as the first choice. Also my personal taste would be to write more comments or links to references as was done in some of the discussion in the previous PR. If it wasn't clear back then it might not be clear to someone in the future either. |
|
And more doctests showing this aspect off would be nice too, as is done on the WMA site. If we have this goodness in there, we might advertise it a little more. |
mmatera
force-pushed
the
more_general_halfinteger_bessel
branch
from
3942e7d to
62e3d44
Compare
|
Here I added a couple of extra rules, including the integral form for BesselJ[0,z]. This can be extended in the future. |
rocky
reviewed
Mar 19, 2023
mathics/autoload/rules/Bessel.m
Outdated
|
|
||
|
|
||
| Unprotect[BesselI] | ||
| BesselI[1/2,z_] := (Sqrt[2/Pi] Sinh[z]) / Sqrt[z] | ||
| BesselI[-1/2,z_] := (Sqrt[2/Pi] Cosh[z]) / Sqrt[z] | ||
| (*Rayleight's formulas for half-integer indices*) |
rocky
reviewed
Mar 19, 2023
mathics/autoload/rules/Bessel.m
Outdated
| Protect[BesselI] | ||
|
|
||
| Unprotect[BesselK] | ||
| (*Rayleight's formulas for half-integer indices*) |
|
LGTM - see spelling typos. Much improved. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the rules for Bessel functions of half integer index.