Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve directed infinity #812

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

rocky
Copy link
Member

@rocky rocky commented Mar 12, 2023

CHANGES.rst

this is a continuation of prior work, not an external API change

arithmetic.py

  • eval_{abs,sign} -> eval_{Abs,Sign};
  • remove MakeBoxes hack - will handle by a more pervasive go-over of Precedence.
  • generic style things changes.
    • Split long URL lines
    • reduce use of %(name)s
    • order class definitions

test_basic.py

Isolate failing DirectedInfinity tests

CHANGES.rst
-----------

this is a continuation of prior work, not an external API
change

arithmetic.py
-------------

* eval_{abs,sign} -> eval_{Abs,Sign};
* remove MakeBoxes hack - will handle by a more pervasive go-over of
Precedence.
* generic style things changes.
  - Split long URL lines
  - reduce use of  %(name)s
  - order class definitions

test_basic.py
-------------

Isolate failing DirectedInfinity tests
@rocky rocky requested a review from mmatera March 12, 2023 19:23
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit 8f1dc7e into improve_DirectedInfinity Mar 12, 2023
@rocky rocky deleted the improve_DirectedInfinity-rocky branch March 12, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants