move basic arithmetic to mathics.eval.arithmetic #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmatera looks like the new files haven't been added into git yet. |
rocky
reviewed
Feb 14, 2023
mathics/eval/arithmetic.py
Outdated
| if prec=None, use floating point arithmetic. | ||
| Otherwise, work with prec bits of precision. | ||
| """ | ||
| # TODO: rocky, please help me with the annotations |
|
LGTM - one small comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts to move the context independent arithmetic to a separate module. Interestingly, just by moving around a little piece of code, the doctest time seems to be reduced in another 10 seconds in my machine, it is, a 13%.