Last of the apply->eval conversions #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocky
force-pushed
the
apply-reduction-7
branch
from
e96b8d8 to
1118199
Compare
Some type annoations for options as a dict were done here.
rocky
force-pushed
the
apply-reduction-7
branch
from
1118199 to
14e1a7c
Compare
|
Unless there are concerns otherwise, I'll merge this in a day or so. |
|
I could not see this in detail right now, but it seems to be straightforward. From my side, merge it when you consider this is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some type annoations for options as a dict were done here.