Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply->eval and minor tweaks #738

Merged
merged 1 commit into from
Jan 10, 2023
Merged

apply->eval and minor tweaks #738

merged 1 commit into from
Jan 10, 2023

Conversation

rocky
Copy link
Member

@rocky rocky commented Jan 9, 2023

Reuse StringLParen and StringRparen
type Annotation on evaluation

@rocky
apply->eval and minor tweaks
1a37d4c 
Reuse StringLParen and StringRparen
type Annotation on evaluation
@rocky rocky force-pushed the apply-reduction3 branch from d574eea to 1a37d4c Compare January 9, 2023 21:30
mmatera
mmatera approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit 3e1420d into master Jan 10, 2023
@rocky rocky deleted the apply-reduction3 branch January 10, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatera mmatera mmatera approved these changes

@TiagoCavalcante TiagoCavalcante Awaiting requested review from TiagoCavalcante

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocky @mmatera