Changes suggested in PR review #622
Conversation
Move core-like assignment interals out of builtins and into core. (We may want to split up core more in the future though) Better sort long list of assignment methods alphabetically Some small RstT tagging in a docstring Remove nonexistent word "evaluable" Add yet another type annotation to a signature Make test assert failure messages unique
| # Below, we key on a string, but Symbol is more correct. | ||
| # | ||
|
|
||
| special_cases = { |
There was a problem hiding this comment.
Maybe this dictionary could be moved also to marhics.core.assignment
Please let's hold off on the others for now. It is not my intention to make additional work and I don't like to see this happen. Make detailed issues describing the problem. Something we keep running into is that basically the code doesn't follow more modern standards of having signatures, ordering imports. (There is a python module called isort that will do this). Naming eval methods with So maybe before modifying a module we should make a pass over that first. |
Move core-like assignment interals out of builtins and into core. (We may want to split up core more in the future though)
Better sort long list of assignment methods alphabetically
Some small RsT tagging in a docstring
Remove nonexistent word "evaluable"
Add yet another type annotation to a signature
Make test assert failure messages unique