Correct LHS evaluation in SetDelayed assignment

CHANGES.rst

@@ -1,4 +1,4 @@
-.. contents::
+	.. contents::
 
 CHANGES
 =======
@@ -41,6 +41,8 @@ Internals
 #. Operator name to unicode or ASCII comes from Mathics scanner character tables.
 #. ``eval*`` methods in `Builtin` classes are considerer as synonyms of ``apply*`` methods.
 #. Modularize and improve the way in which `Builtin` classes are selected to have an associated `Definition`.
+#. `_SetOperator.assign_elementary` was renamed as `_SetOperator.assign`. All the special cases are not handled by the `_SetOperator.special_cases` dict.
+
 
 
 Bugs

Makefile

@@ -112,7 +112,7 @@ clean: clean-cython clean-cache
 
 #: Run py.test tests. Use environment variable "o" for pytest options
 pytest:
-	py.test $(PYTEST_WORKERS) test $o
+	$(PYTHON) -m pytest $(PYTEST_WORKERS) test $o
 
 
 #: Run a more extensive pattern-matching test

mathics/builtin/__init__.py

@@ -20,6 +20,8 @@
     PatternObject,
 )
 
+from mathics.core.pattern import pattern_objects
+
 from mathics.settings import ENABLE_FILES_MODULE
 from mathics.version import __version__  # noqa used in loading to check consistency.
 
@@ -267,7 +269,6 @@ def sanity_check(cls, module):
 mathics_to_python = {}  # here we have: name -> string
 sympy_to_mathics = {}
 
-pattern_objects = {}
 builtins_precedence = {}
 
 new_builtins = _builtins

mathics/builtin/assignments/assignment.py

@@ -144,8 +144,30 @@ class SetDelayed(Set):
      = 2 / 3
     >> F[-3, 2]
      = -2 / 3
+    We can use conditional delayed assignments to define \
+    symbols with values conditioned to the context. For example,
+    >> ClearAll[a,b]; a/; b>0:= 3
+    Set $a$ to have a value of $3$ if certain variable $b$ is positive.\
+    So, if this variable is not set, $a$ stays unevaluated:
+    >> a
+     = a
+    If now we assign a positive value to $b$, then $a$ is evaluated:
+    >> b=2; a
+     =  3
     """
 
+    #  I WMA, if we assign a value without a condition on the LHS,
+    # conditional values are never reached. So,
+    #
+    # Notice however that if we assign an unconditional value to $a$, \
+    # this overrides the condition:
+    # >> a:=0; a/; b>1:= 3
+    # >> a
+    # = 0
+    #
+    # In Mathics, this last line would return 3
+    # """
+
     operator = ":="
     attributes = A_HOLD_ALL | A_PROTECTED | A_SEQUENCE_HOLD
 
@@ -203,7 +225,7 @@ def apply(self, f, lhs, rhs, evaluation):
             return
 
         rhs = rhs.evaluate(evaluation)
-        self.assign_elementary(lhs, rhs, evaluation, tags=[name])
+        self.assign(lhs, rhs, evaluation, tags=[name])
         return rhs
 
 
@@ -228,7 +250,7 @@ def apply(self, f, lhs, rhs, evaluation):
             evaluation.message(self.get_name(), "sym", f, 1)
             return
 
-        if self.assign_elementary(lhs, rhs, evaluation, tags=[name]):
+        if self.assign(lhs, rhs, evaluation, tags=[name]):
             return SymbolNull
         else:
             return SymbolFailed

mathics/builtin/assignments/clear.py

@@ -22,14 +22,20 @@
     Atom,
     Symbol,
     SymbolNull,
-    system_symbols,
+    symbol_set,
 )
 
 from mathics.core.systemsymbols import (
     SymbolContext,
     SymbolContextPath,
+    SymbolDownValues,
     SymbolFailed,
+    SymbolMessages,
+    SymbolNValues,
     SymbolOptions,
+    SymbolOwnValues,
+    SymbolSubValues,
+    SymbolUpValues,
 )
 
 from mathics.core.atoms import String
@@ -320,12 +326,12 @@ def apply(self, expr, evaluation):
         return SymbolNull
 
 
-SYSTEM_SYMBOL_VALUES = system_symbols(
-    "OwnValues",
-    "DownValues",
-    "SubValues",
-    "UpValues",
-    "NValues",
-    "Options",
-    "Messages",
+SYSTEM_SYMBOL_VALUES = symbol_set(
+    SymbolDownValues,
+    SymbolMessages,
+    SymbolNValues,
+    SymbolOptions,
+    SymbolOwnValues,
+    SymbolSubValues,
+    SymbolUpValues,
 )