Another round of improving the mathics.core.definitions module. #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify arguments in definition initialization. * move autoload_files to mathics.session. * move get_file_time to mathics.eval.files_io.files * Simplify the way in which the different sets of rules are accessed.
rocky
reviewed
Jan 10, 2025
CHANGES.rst
Outdated
| @@ -62,7 +62,9 @@ API incompatibility | |||
|
|
|||
| * ``Matcher`` now requires an additional ``evaluation`` parameter | |||
| * ``Romberg`` removed as an ``NIntegrate[]`` method. It is depcrecated in SciPy and is to be removed by SciPy 1.15. | |||
| * `Definitions.get_ownvalue` now returns a `BaseElement` instead of a `BaseRule` object. | |||
| * The signature of the ``Definition.__init__`` now receives a single dict parameter instead of the severa `*values` parameters. | |||
There was a problem hiding this comment.
severa -> several.
It is probably time to run through codespell.
But note that "inout" and "shbang" are ok.
There was a problem hiding this comment.
I did run codespell, and it did not detect it.
|
LGTM - a lot of good stuff in here. I notice we still have a lot of places where we might annotate And I saw (but I forget where) where there is this variable, I think it was ironically named "types" which had a changing type value which mypy notices. But there's always more to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition.__init__method.autoload_filestomathics.session.get_file_timetomathics.eval.files_io.filesposof{get|set}_valuesinclude the"values"in theposition key. For example,pos="up"now ispos="upvalues". This removes the need to rebuild the key string each time a list of rules is requested.