Split the merging definitions code from Definitions.get_definition #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: R. Bernstein <[email protected]>
|
LGTM |
rocky
reviewed
Jan 10, 2025
| @@ -1150,3 +880,281 @@ def get_history_length(self) -> int: | |||
| if history_length is None or history_length > 100: | |||
| history_length = 100 | |||
| return history_length | |||
|
|
|||
|
|
|||
| def autoload_files( | |||
There was a problem hiding this comment.
Why was this moved to the end?
Also, autoloading files feels more like a session kind of thing than a "core" function. And finally the mathics.core.definitions module is pretty large so moving this somewhere else would balance things in terms of size too.
There was a problem hiding this comment.
Because merge_definitions requires the class Definition to be defined, and seems reasonable to out all the functions together.
And yes, some of these functions should be moved to other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the simplification of the code in the
mathics.code.definitionsmodule.