Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add eslint + fix errors + control on CI/CD #154

Merged
merged 1 commit into from
Nov 20, 2023
Merged

feature: add eslint + fix errors + control on CI/CD #154

merged 1 commit into from
Nov 20, 2023

Conversation

joacoc
Copy link
Contributor

@joacoc joacoc commented Nov 20, 2023

This PR adds eslint to the project and adds a control step in the GitHub Actions for the CI/CD process.
I solved all the errors that eslint was mentioning.

@joacoc joacoc requested a review from bobbyiliev as a code owner November 20, 2023 16:35
bobbyiliev
bobbyiliev approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@joacoc joacoc merged commit 60bd08e into main Nov 20, 2023
1 check passed
@joacoc joacoc deleted the eslint branch November 20, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joacoc @bobbyiliev