27: Add object count #115
Merged
27: Add object count #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joacoc
approved these changes
Oct 26, 2023
src/providers/schema.ts
Outdated
| @@ -52,14 +52,21 @@ export default class DatabaseTreeProvider implements vscode.TreeDataProvider<Nod | |||
| console.log("SchemaReader: ", schema, schemas, schemaName); | |||
|
|
|||
| if (schema) { | |||
| const sourceCount = await this.getSources(schema.id).then(s => s.length); | |||
There was a problem hiding this comment.
What if, instead of using multiple await statements for individual queries, we use a single query to retrieve all the counts, or put all the promises in one array and execute them in parallel?
E.g.:
const promises = [];
promises.push(this.getSources(schema.id).then(s => s.length));
...
const [sourceCount, ...] = await Promise.all(promises);There was a problem hiding this comment.
Good idea! Just refactored this as requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an object count to the
Schema Explorersection which will show a count of all objects:Also fixes a small bug where the
getSourcesmethod was selecting from themz_sinkstable resulting in always 0 sources.Closes #27