MySQL source resource #486
Conversation
bobbyiliev
requested review from
arusahni and
rjobanp
and removed request for
a team
| return b | ||
| } | ||
|
|
||
| func (b *SourceMySQLBuilder) Size(s string) *SourceMySQLBuilder { |
There was a problem hiding this comment.
This is used by the read func to get the size of the cluster where the source is created in:
This was part of the migration that allowed us to remove notion of linked clusters in Terraform.
docs/resources/source_mysql.md
Outdated
| - `ownership_role` (String) The owernship role of the object. | ||
| - `region` (String) The region to use for the resource connection. If not set, the default region is used. | ||
| - `schema_name` (String) The identifier for the source schema. Defaults to `public`. | ||
| - `table` (Block List) Specifies the tables to be included in the source. If not specified, all tables are included. (see [below for nested schema](#nestedblock--table)) |
There was a problem hiding this comment.
should we also add support for the FOR SCHEMAS option?
There was a problem hiding this comment.
Not planing to add FOR SCHEMAS option as part of this discussion here which caused some major issues with the Postgres source.
Just reworked an old PR to patch this on the Postgres side, will cherry pick some of the changes here as well.
| return diag.FromErr(err) | ||
| } | ||
| o := materialize.MaterializeObject{ObjectType: "SOURCE", Name: sourceName, SchemaName: schemaName, DatabaseName: databaseName} | ||
| // b := materialize.NewSource(metaDb, o) |
There was a problem hiding this comment.
is this relevant? should we allow updating a source object at all?
There was a problem hiding this comment.
Yes, you can update some propertites like the the name of the source, comments, ownership and etc.
I still have to work on implementing the subsources as well, eg. adding and removing subsources ALTER SOURCE "database"."schema"."source" ADD SUBSOURCE "table_1" AS "table_alias";
There was a problem hiding this comment.
Ah got it! Just so you know the ALTER SOURCE statements are not yet supported for MySQL.
There was a problem hiding this comment.
Ah yes, I've created a follow up issue for this: #490
This is mainly intended to lay the ground work for the MySQL source resource. Probably there are some missing configuration options that I'll have to add here.