[WIP] AWS Connection #417
Closed
[WIP] AWS Connection #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehume
commented
Dec 18, 2023
| @@ -71,6 +71,19 @@ services: | |||
| POSTGRES_PASSWORD: ${POSTGRES_PASSWORD:-c2VjcmV0Cg==} | |||
| POSTGRES_USER: ${POSTGRES_USER:-postgres} | |||
| POSTGRES_HOST: ${POSTGRES_HOST:-postgres} | |||
|
|
|||
| localstack: | |||
There was a problem hiding this comment.
Including localstack with iam service for integration testing. Will be able to calibrate more when the DDL is enabled in the image.
| #/bin/bash | ||
| set -x | ||
|
|
||
| awslocal iam create-user --user-name terraform |
There was a problem hiding this comment.
Any aws CLI commands needed for localstack setup
|
|
||
| // Note: Cannot set nested attributes with this SDK | ||
| // https://github.com/hashicorp/terraform-plugin-sdk/issues/459 | ||
| // if err := d.Set("access_key_id.0.text", s.AccessKeyId.String); err != nil { |
There was a problem hiding this comment.
The system catalog has different columns if the text or secret value is used for creation. Unfortunately we cannot save that information separately to different nested values within these attributes.
| } | ||
|
|
||
| var connectionAwsQuery = NewBaseQuery(` | ||
| SELECT |
There was a problem hiding this comment.
Haven't been able to fully vet this query since the system table is not in the image yet. This is based on the privatelink query
Merged
|
Closing this PR in favor of #492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395
Add new resource
materialize_connection_aws.To Do: