Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Subsource #413

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Test Subsource #413

merged 3 commits into from
Dec 28, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Dec 15, 2023

Fixes #393

Include tests to ensure that subsources are created within the correct namespace if top level database_name and schema_name are set for the source.

@dehume dehume added the testing Issue related to tests label Dec 15, 2023
@bobbyiliev bobbyiliev marked this pull request as ready for review December 28, 2023 13:56
@bobbyiliev bobbyiliev self-requested a review as a code owner December 28, 2023 13:56
@bobbyiliev bobbyiliev merged commit 0ed39d8 into main Dec 28, 2023
4 checks passed
@bobbyiliev bobbyiliev deleted the Test-Subsource branch December 28, 2023 13:57
@bobbyiliev bobbyiliev changed the title [WIP] Test Subsource Test Subsource Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

Assignees
No one assigned
Labels
testing Issue related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Checks on Subsource Naming
2 participants
@dehume @bobbyiliev