Duplicate Datasources #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehume
commented
Dec 12, 2023
| @@ -26,7 +26,7 @@ func TestTransformIdWithRegion(t *testing.T) { | |||
| "expected": "aws/us-east-1:u1", | |||
| }, | |||
| } | |||
| for tc, _ := range testCases { | |||
| for tc := range testCases { | |||
There was a problem hiding this comment.
Unrelated, just from running format
bobbyiliev
requested changes
Dec 12, 2023
dehume
commented
Dec 12, 2023
| @@ -2,6 +2,12 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Features | |||
| * Allow Avro comments (`avro_doc_type` and `avro_doc_column`) for resource `materialize_sink_kafka` [#373](https://github.com/MaterializeInc/terraform-provider-materialize/pull/373) | |||
There was a problem hiding this comment.
Was not included in the last PR
| @@ -114,6 +114,7 @@ var materializedViewQuery = NewBaseQuery(` | |||
| SELECT id, comment | |||
| FROM mz_internal.mz_comments | |||
| WHERE object_type = 'materialized-view' | |||
| AND object_sub_id IS NULL | |||
There was a problem hiding this comment.
This is the actual fix for the duplication issue. The majority of the PR is just testing
bobbyiliev
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408
Investigation for duplicate datasources. It seems that the issue was with
materialize_materialized_viewsthat contained a top level comment as well as column level comments. This cannot be set via the provider (mostly likely dbt) which was leading to duplicated rows in the data sources. IncludingAND object_sub_id IS NULLto the subquery removes the column level comments.Also including acceptance tests for all data sources: