Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grant Id Migration #401

Merged
merged 9 commits into from
Dec 8, 2023
Merged

Grant Id Migration #401

merged 9 commits into from
Dec 8, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Dec 6, 2023 •
edited
Loading

As per #399. Updating the grant resources for the id migration. Overall these lined up more with the other resources than I expected.

@dehume dehume mentioned this pull request Dec 7, 2023
Closed
@dehume dehume changed the title [WIP] Grant Id Migration Grant Id Migration Dec 7, 2023
@dehume dehume marked this pull request as ready for review December 7, 2023 21:22
@dehume dehume requested a review from bobbyiliev as a code owner December 7, 2023 21:23
bobbyiliev
bobbyiliev approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for working on this and the quick implementation!

@dehume dehume merged commit 051fdb4 into main Dec 8, 2023
6 checks passed
@dehume dehume deleted the Grant-Region-Id branch December 8, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dehume @bobbyiliev