Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role Session Variable #330

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Role Session Variable #330

merged 4 commits into from
Oct 17, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Oct 6, 2023

Allow session variables to be included as part of Role resources.

@dehume dehume changed the title [WIP ]Role Session Variable [WIP ] Role Session Variable Oct 6, 2023
@dehume dehume changed the title [WIP ] Role Session Variable [WIP] Role Session Variable Oct 6, 2023
@dehume dehume linked an issue Oct 6, 2023 that may be closed by this pull request
Copy link
Contributor Author

@dehume dehume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows role session variables to be set upon creation. However there is not a way (that I know of) to query the state of these session variables after creation.

Detail: "Unable to enable webhook sources for authenticated Materialize client",
})
return nil, diags
flags := []string{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifying feature flags

@@ -79,3 +79,35 @@ var aliases = map[string]string{
"int2": "smallint",
"uint": "uint4",
}

var session_variables = []string{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just used for validation within the resource. Not sure if we want to this just since it might be harder to keep things in sync.

@dehume dehume changed the title [WIP] Role Session Variable Role Session Variable Oct 9, 2023
@dehume dehume marked this pull request as ready for review October 9, 2023 12:51
@dehume dehume requested a review from bobbyiliev as a code owner October 9, 2023 12:51
@dehume dehume merged commit d4b3f50 into main Oct 17, 2023
@dehume dehume deleted the Role-Session-Variable branch October 17, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support session variable defaults for roles
2 participants