Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require FOR ALL TABLES Multi Output Sources #310

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Require FOR ALL TABLES Multi Output Sources #310

merged 1 commit into from
Sep 11, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Sep 11, 2023

Include FOR ALL TABLES as a non configurable part of the SQL syntax for multi output load generator sources (auction and marketing)

@dehume dehume added the bug Something isn't working label Sep 11, 2023
@dehume dehume linked an issue Sep 11, 2023 that may be closed by this pull request
Multi-output loadgen sources will require FOR ALL TABLES #307
Closed
@dehume dehume requested a review from bobbyiliev September 11, 2023 16:01
bobbyiliev
bobbyiliev approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dehume dehume merged commit 1677879 into main Sep 11, 2023
@dehume dehume deleted the Require-All-Tables branch September 11, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-output loadgen sources will require FOR ALL TABLES
2 participants
@dehume @bobbyiliev