Initial webhook source setup #271
Conversation
pkg/materialize/source_webhook.go
Outdated
| size string // TODO: size is not supported for webhook sources | ||
| bodyFormat string | ||
| includeHeaders bool | ||
| checkOptions []string |
There was a problem hiding this comment.
Should this be a custom struct like
type checkOptions struct {
field string
alias string
}
Then in the resource we can put in validation to ensure they are only using a field of type BODY, HEADER, or SECRET
There was a problem hiding this comment.
Just updated this, but also realized that it might be a bit more complex than my current implementation as I'll have to add a check for the SECRET as well to make sure that an actual secret is provided
| `, sourceName) | ||
| } | ||
|
|
||
| func testAccCheckSourceWebhookExists(name string) resource.TestCheckFunc { |
There was a problem hiding this comment.
Realizing we could just use the same function for all source acceptance tests rather than defining a custom one for each source type. At least for any source that just uses ScanSource.
| Optional: true, | ||
| ForceNew: true, | ||
| }, | ||
| "size": { |
There was a problem hiding this comment.
Based on the TODO above. Size will eventually be supported?
There was a problem hiding this comment.
Not 100% sure if size will ever be supported, as far as I can tell the IN CLUSTER parameter is required. So this is a bit different compared to the rest of the sources that we have. The TODO is mainly for coming up with a way of reimplementing the sourceQuery in a clean way.
| if err := b.Create(); err != nil { | ||
| return diag.FromErr(err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Since ownership can be set. Will need a block for the adding ownership.
There was a problem hiding this comment.
Good point! Just added this.
bobbyiliev
force-pushed
the
270-webhook-source
branch
5 times, most recently
from
65502a6 to
d5d713c
Compare
bobbyiliev
force-pushed
the
270-webhook-source
branch
from
d5d713c to
6570806
Compare
Adding the very initial work for supporting webhook sources.
Things that still need to be ironed out:
checkExpressioncheckOptionssizedoes not apply to the webhook source, at least judging by the grammar fileCloses #270