Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support FORMAT JSON for sources #227

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Support FORMAT JSON for sources #227

merged 1 commit into from
Jul 7, 2023

Conversation

benesch
Copy link
Member

@benesch benesch commented Jul 7, 2023

Part of MaterializeInc/database-issues#6125.

@benesch
Support FORMAT JSON for sources
8ed69e2 
Part of MaterializeInc/materialize#20387.
@benesch benesch requested a review from dehume July 7, 2023 05:41
@benesch benesch merged commit afd70f1 into main Jul 7, 2023
@morsapaes
Copy link
Contributor

morsapaes commented Jul 10, 2023 •
edited
Loading

Nit: it'd be helpful to adopt the best practice of adding an entry to CHANGELOG.md under Unreleased for any PR introducing new functionality (much like we do for the dbt adapter). @dehume @bobbyiliev It makes it easier to get an overview of what's coming in the next release (and saves you some time then!).

@dehume dehume deleted the format-json branch September 13, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehume dehume dehume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benesch @morsapaes @dehume