Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Index Object Schema #202

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Fix Index Object Schema #202

merged 1 commit into from
Jun 14, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Jun 14, 2023

The index acceptance test was flaky because there was an issue with the read. The object schema was mistakenly set to the object name. Fixed and updated IndexParams to have more descriptive fields.

@dehume dehume added the bug Something isn't working label Jun 14, 2023
@dehume dehume requested a review from bobbyiliev June 14, 2023 19:25
@dehume dehume changed the title Fix Index Schema Fix Index Object Schema Jun 14, 2023
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dehume dehume merged commit 58c8c6e into main Jun 14, 2023
@dehume dehume deleted the Fix-Index-Schema branch June 14, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants