Skip to content

Commit

Permalink
Remove confusing line from migration guide
Browse files Browse the repository at this point in the history
  • Loading branch information
bobbyiliev committed Oct 29, 2024
1 parent 147606a commit 8d433e5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions docs/guides/materialize_source_table.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,6 @@ resource "materialize_source_kafka" "kafka_source" {

In the `lifecycle` block, add the `ignore_changes` meta-argument to prevent Terraform from trying to update these attributes during subsequent applies, that way Terraform won't try to update these values based on incomplete information from the state as they will no longer be defined in the source resource itself but in the new `materialize_source_table_{source_type}` resources.

> Note: Once the migration process is fully implemented on the Materialize side and the attributes will have to be updated as no-op in future versions of the provider. That way the `ignore_changes` block will no longer be required. At that point, Terraform will correctly handle these attributes without needing the extra lifecycle configuration. Keep an eye on upcoming releases for this change.
### Step 4: Update Terraform State

After removing the `table` blocks and the table/topic specific attributes from your source resources, run `terraform plan` and `terraform apply` again to update the Terraform state and apply the changes.
Expand Down
2 changes: 0 additions & 2 deletions templates/guides/materialize_source_table.md.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,6 @@ resource "materialize_source_kafka" "kafka_source" {

In the `lifecycle` block, add the `ignore_changes` meta-argument to prevent Terraform from trying to update these attributes during subsequent applies, that way Terraform won't try to update these values based on incomplete information from the state as they will no longer be defined in the source resource itself but in the new `materialize_source_table_{source_type}` resources.

> Note: Once the migration process is fully implemented on the Materialize side and the attributes will have to be updated as no-op in future versions of the provider. That way the `ignore_changes` block will no longer be required. At that point, Terraform will correctly handle these attributes without needing the extra lifecycle configuration. Keep an eye on upcoming releases for this change.

### Step 4: Update Terraform State

After removing the `table` blocks and the table/topic specific attributes from your source resources, run `terraform plan` and `terraform apply` again to update the Terraform state and apply the changes.
Expand Down

0 comments on commit 8d433e5

Please sign in to comment.