Fix AWS connection empty internal table (#630)

* Fix AWS connection empty internal table * Add dummy aws-connection-role-arn
MaterializeInc · Aug 9, 2024 · 5881b6c · 5881b6c
1 parent 8a08aa5
commit 5881b6c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -15,6 +15,9 @@ services:
       - --bootstrap-builtin-probe-cluster-replica-size=3xsmall
       - --availability-zone=test1
       - --availability-zone=test2
+      - --aws-account-id=123456789000
+      - --aws-external-id-prefix=eb5cb59b-e2fe-41f3-87ca-d2176a495345
+      - --aws-connection-role-arn=arn:aws:iam::123456789000:role/MaterializeConnection
       - --system-parameter-default=max_clusters=100
       - --system-parameter-default=max_sources=100
       - --system-parameter-default=max_aws_privatelink_connections=10
@@ -37,6 +40,9 @@ services:
       - --bootstrap-builtin-probe-cluster-replica-size=3xsmall
       - --availability-zone=test1
       - --availability-zone=test2
+      - --aws-account-id=123456789000
+      - --aws-external-id-prefix=eb5cb59b-e2fe-41f3-87ca-d2176a495345
+      - --aws-connection-role-arn=arn:aws:iam::123456789000:role/MaterializeConnection
       - --system-parameter-default=max_clusters=100
       - --system-parameter-default=max_sources=100
       - --system-parameter-default=max_aws_privatelink_connections=10

diff --git a/pkg/resources/resource_connection_aws.go b/pkg/resources/resource_connection_aws.go
@@ -132,13 +132,13 @@ func connectionAwsRead(ctx context.Context, d *schema.ResourceData, meta interfa
 	// 	return diag.FromErr(err)
 	// }
 
-	// if err := d.Set("assume_role_arn", s.AssumeRoleArn.String); err != nil {
-	// 	return diag.FromErr(err)
-	// }
+	if err := d.Set("assume_role_arn", s.AssumeRoleArn.String); err != nil {
+		return diag.FromErr(err)
+	}
 
-	// if err := d.Set("assume_role_session_name", s.AssumeRoleSessionName.String); err != nil {
-	// 	return diag.FromErr(err)
-	// }
+	if err := d.Set("assume_role_session_name", s.AssumeRoleSessionName.String); err != nil {
+		return diag.FromErr(err)
+	}
 
 	if err := d.Set("ownership_role", s.OwnerName.String); err != nil {
 		return diag.FromErr(err)