make ThreadedProducer clonable like BaseProducer #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The threaded producer was not `Clone` due to handling the background thread join handle but that can easily be stored in an `Arc` that the last drop of the client unwraps and terminates the background thread. `Arc::into_inner` guarantees that exactly one thread will manage to unwrap the handle.
benesch
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The threaded producer was not
Clonedue to handling the background thread join handle but that can easily be stored in anArcthat the last drop of the client unwraps and terminates the background thread.Arc::into_innerguarantees that exactly one thread will manage to unwrap the handle.this is a backport of fede1024#731