Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for binary format in tuple data #28

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

imor
Copy link

@imor imor commented Nov 8, 2024

This PR adds support for parsing a TupleData in binary format as defined in the docs. This is useful for the case when the START_REPLICATION command contains the binary option for pgoutput plugin defined on this docs page.

@imor
Copy link
Author

imor commented Nov 11, 2024

@petrosagg could you please take a look at this PR. It adds support for binary format in TupleData. Also has the postgres-replication crate been published to crates.io? Can a new version be published after merging this PR?

@petrosagg
Copy link

@imor thanks a lot for this PR, the change looks great! Somehow it slipped past my attention.

Unfortunately postgres-replication can't be published in crates.io for now because it depends on a git dependency of the forked tokio-postgres crate. There is a long-standing upstream PR in rust-postgres that would enable that but it's been open for many years now

@petrosagg petrosagg merged commit 7d2f14e into MaterializeInc:master Nov 28, 2024
3 of 4 checks passed
@imor imor deleted the binary_tuples branch November 29, 2024 05:01
@imor
Copy link
Author

imor commented Nov 29, 2024

Ah ok, no worries. Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants