Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer 16 messages in copy-both involved channels #26

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

petrosagg
Copy link

I noticed that I introduced a regression as part of #25. I created a local benchmark and captured flamegraphs which indicated that a lot of time was spent parking and unparking threads and in general channel synchronization.

I don't know if this is due to the channel implementation of futures_channel being less efficient than say tokio's mpsc channels but increasing their capacity brings the performance back to previous levels since any synchronization overheads are now both amortized over more operations and parking is less likely to happen if both ends are continually draining the channels.

@petrosagg petrosagg requested a review from rjobanp September 2, 2024 15:22
@petrosagg petrosagg merged commit 08105f5 into MaterializeInc:master Sep 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants