buffer 16 messages in copy-both involved channels #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that I introduced a regression as part of #25. I created a local benchmark and captured flamegraphs which indicated that a lot of time was spent parking and unparking threads and in general channel synchronization.
I don't know if this is due to the channel implementation of
futures_channel
being less efficient than say tokio's mpsc channels but increasing their capacity brings the performance back to previous levels since any synchronization overheads are now both amortized over more operations and parking is less likely to happen if both ends are continually draining the channels.