-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove replication specific functionality #12
Conversation
This reverts commit 83dd8f0.
…ation" This reverts commit 6a7b2ee.
This reverts commit 395822a.
This reverts commit 219890c.
This reverts commit 7dce3e4.
This reverts commit 65b5f54.
This reverts commit 7fe532b.
This reverts commit d0476a8.
Co-authored-by: Petros Angelatos <[email protected]>
Signed-off-by: Petros Angelatos <[email protected]>
|
Signed-off-by: Petros Angelatos <[email protected]>
Signed-off-by: Petros Angelatos <[email protected]>
999c700
to
bf227f4
Compare
Just wanted to mention that: For several months I have been relying on the petrosagg "copy-both" branch for logical-replication support: https://github.com/petrosagg/rust-postgres/tree/copy-both Earlier today I tried to do a fresh build, and got a compile error: I cleared the docker cache and such, then realized the issue may have been caused by a force-push to petrosagg's copy-both branch, which then changed the sha-1 signatures of the commits. On checking the Github repo, it appears that was the case. I attempted to resolve by trying the latest version of the "copy-both" branch, and got this error:
I then tried various other commits, but was still hitting compile errors (I eventually went back far enough to where the I then tried various commits from the I eventually remembered that I had made a fork of the petrosagg fork previously, as a backup plan for exactly this sort of situation. After switching to it, my project's build worked again as expected. (so it does seem to be from the force-pushed changes, rather than a caching issue) Maybe this is already a known issue, but I figured I would mention it. (if for no other reason, to help other people hitting this issue and searching on it) |
superseded by #25 |
This PR brings our fork at the same state as the upstream
rust-postgres
PR for anything that is related to replication. Specifically this PR makesrust-postgres
only offer support for a genericCopyBoth
query mode and no additional support for the replication protocol. This brings in bug fixes that have existed in the upstream PR version of the code that have been missing from hereThe replication protocol specific bits have been moved to
mz_postgres_util
in this PR MaterializeInc/materialize#17114