-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional_emails field on the Customer type #31
Conversation
@benesch Thank you for the library and accepting PRs, let me know anything else! I didn't actually run the tests because of the emails and Orb key, but if they pass it should be good. Please let me know anything else! |
Thanks for the PR! I triggered a CI run. @arusahni could you handle the review here? |
The test failure is related to GHA not sharing tokens across forks. I can switch to a branch if you grant me writer to the repo, that would dodge the issue, or maybe there's another way? cc @arusahni |
Closes #30 |
Ah, yeah, that's annoying. I can pull this down and run the Linux tests locally, and we can do code review on this PR. Once it looks good to merge I'll open a branched PR with your commits (preserving your authorship) and we can get the final CI run and merge this in. Does that sound okay to you? |
Sounds good! Just let me know if you change you mind, I can follow another process to make it easier for you if I have another change request later. |
No worries at all! We very much appreciate your contributions :-) I'll try to get to this within the next day or so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I can verify that, with the typo fix I suggested, the tests pass. Let's get a few updates made and then we can close it for me to resubmit via a branch:
- Revert the
Cargo.toml
version bump. - Apply the email address fix suggestion.
- Add an entry to
CHANGELOG.md
for this. Since we're using Cargo release, we use this convention for recording updates. Spefically, place the entry under the "Unreleased" header. It will automatically be associated with the new version when we cut the release. - Let's squash the commits into a single one with a semantic commit message.
482fd3e
to
68d9003
Compare
@arusahni ok done |
Support additional_emails on the Customer type
Orb reference docs