Add support for fetching customer costs #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arusahni
force-pushed
the
feat/customer-costs
branch
4 times, most recently
from
b0621d2 to
d5a819c
Compare
Depending on the time of day the event tests are run, the generated events may fall in the future. Orb's search endpoint *defaults* to a `timeframe_end` of `now()`, so future events are excluded even if there are ID matches. By explicitly setting the `timeframe_end` to one second after the furthest future event we can ensure all events will always be returned.
Some runs of the subscription test pick up subscriptions from previous runs. Minimize flakes by setting a floor for the fetched subscriptions based on the first one created in the current test run.
Previously, when one amended an event, only the latest version of the event was returned by the event search endpoint. That behavior has since been revised by Orb, and now _all_ versions of events are returned. Update the test to validate what we care about -- specifically, that the amended event is returned by the search endpoint.
…t search results. Orb has since changed the behavior of event amendment and deprecation, and now always returns events, whether they are amended or deprecated.
arusahni
force-pushed
the
feat/customer-costs
branch
from
d5a819c to
5d0531a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for fetching customer costs. It only populates a subset of the fields and pricing strategies, matching what we need to internally support at the moment. To support testing, I created an additional plan in our test account that has a matrix price as well.
I'm very much open to bikeshedding the names of these structs.