Customer credit ledger entry creation, and customer credit enumeration #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arusahni
force-pushed
the
feat/customer-credit-ops
branch
from
ccf5fd7 to
d33ed09
Compare
|
@arusahni would you mind conscripting someone else for this review? I took a quick skim but I won't have time to go deeper—and it's long past time for me to get out of the business of maintainership of this crate entirely! |
arusahni
force-pushed
the
feat/customer-credit-ops
branch
from
484dade to
99ce79e
Compare
guswynn
approved these changes
Nov 28, 2023
|
Looks like it'll work 🆗 |
|
@benesch could I get another admin merge here since I had to bump the MSRV again? |
I bumped the MSRV in the required checks, too. Will merge, to lock it in, but you should also be empowered to merge yourself too, going forward! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for fetching the credit balances associated with the customer. To support testing this functionality, this also adds support for creating a subset of customer ledger entry types (credit, void).
I'm very much open to some bikeshedding on the naming for the ledger entry base type. Staring at this for too long had me feeling smurfy.
It also bumps the MSRV because some deps use
once_celland we want to use the stabilized version.