Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/plan metadata #17

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Feat/plan metadata #17

merged 4 commits into from
Nov 23, 2023

Conversation

arusahni
Copy link
Contributor

Re-creating PR #16 because I had to adjust the build matrix, which ended up leaving phantom pending tasks that made it unmergable.

Orb now allows users to attach arbitrary key/value metadata to plans. Add support for this to the crate.

Additionally, clean up some tests:

  • fix instances where we weren't actually interpolating locals
  • temporarily work around Orb API regression re: None values in the events response
  • retry the event amendment query a few times to account for variance in timing
  • re-order the expected event list query results to match the query params order

@arusahni arusahni requested a review from benesch November 22, 2023 21:37
@benesch benesch merged commit e0b93b0 into main Nov 23, 2023
7 of 10 checks passed
@benesch benesch deleted the feat/plan-metadata branch November 23, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants