This repository has been archived by the owner on Dec 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quodlibetor
reviewed
Mar 5, 2021
|
||
typeAliases.put("boolean", "bool"); | ||
typeAliases.put("decimal", "numeric"); | ||
typeAliases.put("json", "jsonb"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these (json/jsonb) aren't technically identical but they should behave similarly enough for metabase purposes so it's probably fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah--it's definitely sort of weird! but we do technically list it as an alias here.
quodlibetor
approved these changes
Mar 5, 2021
For posterity, I tested this locally by:
|
JLDLaughlin
commented
Mar 5, 2021
@@ -117,7 +117,11 @@ protected void finalize() throws IOException { | |||
// forcibly close it because super.finalize() may keep the FD open, which may prevent | |||
// file deletion | |||
close(); | |||
super.finalize(); | |||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to make this change to build the jar locally!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user surfaced the following Metabase error (using our
pgjdbc
fork):It turns out our
typeAliases
info didn't include all of the available aliases for Materialize's built-in types.