This repository has been archived by the owner on Dec 18, 2021. It is now read-only.
Update getTables to only return materialized views #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2020
JLDLaughlin
added a commit
that referenced
this pull request
Apr 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We use this pgjdbc fork as a connector between Metabase and Materialize. Metabase uses this JDBC code to query Materialize -- both automatically and when prompted. For instance, Metabase queries Materialize automatically upon syncing in an attempt to generate dashboard queries the user might be interested in.
The Problem
To generate suggested queries, Metabase iterates through each item returned by
getTablesand queries them in order to automatically generate potential insights. In our case,getTablescurrently returns all tables and views in Materialize. But, as of recently, we can only query materialized views. Since neither tables nor views are materialized, Metabase is unable to generate insights from them.The Solution
Only return materialized views!
I tested this locally via Docker and it worked.