This repository has been archived by the owner on Dec 18, 2021. It is now read-only.
[mz] unfork getTables, update forked getColumns implementation #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous query didn't allow for querying schema-qualified objects in Materialize, exluding non-public objects from being visible in Metabase.
JLDLaughlin
changed the title
|
Also, @quodlibetor, should I create a new v0.0.8 release (of our Metabase driver) for this? Or just replace v0.0.7, since it was supposed to do this all along? |
quodlibetor
approved these changes
Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous query didn't allow for querying schema-qualified objects
in Materialize, exluding non-public objects from being visible in
Metabase. Unfortunately we can't yet unfork
getColumnsbecause wedon't yet support
pg_catalog.pg_attrdef.Screen.Recording.2021-04-26.at.1.47.19.PM.mov