Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database syncing settings #48

Merged
merged 10 commits into from
May 29, 2024
Merged

Database syncing settings #48

merged 10 commits into from
May 29, 2024

Conversation

bobbyiliev
Copy link
Contributor

Adding the default advanced options to the driver configuration.

(def default-advanced-options
  "Vector containing the three most common options present in the advanced option section of the DB connection form."
  [auto-run-queries let-user-control-scheduling metadata-sync-schedule cache-field-values-schedule fingerprint])

Which will allow the user the configure the following:

image

@bobbyiliev bobbyiliev requested a review from benesch May 29, 2024 08:11
Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for turning this around so quickly, Bobby!

Comment on lines +39 to +40
- advanced-options-start
- default-advanced-options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg, that ended up being so simple in the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha yea, but it was also a good reminder to get some other pending things updated as well!

@bobbyiliev bobbyiliev merged commit b18ee0d into master May 29, 2024
2 checks passed
@bobbyiliev bobbyiliev deleted the Database-Syncing-Settings branch May 29, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants