Add release GH workflow #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehume
approved these changes
Aug 22, 2023
|
I think you should be able to set the workflow's GitHub token to have release write permissions? https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
|
|
Ah yes! Good point @benesch! Just updated this accordingly. |
|
Sweet! Unrequesting my review since I don't have time to take a look, but let me know if the GitHub token approach doesn't end up working. |
|
I've tested it with my fork and it seems to work as expected. Thank you for that suggestion Nikhil! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a release workflow to build a new jar and create a GH release on tag.
We need to create a new GH token and add it as a secret:secrets.RELEASE_TOKENas the defaultsecrets.GITHUB_TOKENTdoes not have the repo privileges to create releases.Totally open to suggestions here!
Closes #23