Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom JDBC driver #19

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Remove custom JDBC driver #19

merged 4 commits into from
Jul 21, 2023

Conversation

bobbyiliev
Copy link
Contributor

As part of the initial work for the Metabase Materialize partner driver, this PR removes the old custom JDBC connector which was required in the past.

metabase-materialize-driver

Copy link
Contributor

@joacoc joacoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two subtle details.

resources/metabase-plugin.yaml Outdated Show resolved Hide resolved
resources/metabase-plugin.yaml Outdated Show resolved Hide resolved
bobbyiliev and others added 2 commits July 19, 2023 20:18
@bobbyiliev bobbyiliev merged commit 3493e59 into master Jul 21, 2023
@bobbyiliev bobbyiliev deleted the remove-custom-jdbc-driver branch July 21, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants