Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move analysis panics into Derived* #30634

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

frankmcsherry
Copy link
Contributor

Our analysis framework allows you to build on various other analyses, but to access them you need to probe the collection to get the results, and .. potentially they might not exist (due to a logic bug). There is nothing to do other than panic, and all the "user" code immediately panics with the same messages: "Analysis FOO was required, but is missing".

This PR moves those panics into the analysis container, indicating that some methods may panic when invoked with arguments that cannot be found, not unlike array out of bounds access or key not found errors.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@frankmcsherry frankmcsherry requested review from mgree and ggevay December 4, 2024 13:43
@frankmcsherry frankmcsherry marked this pull request as ready for review December 4, 2024 13:43
@frankmcsherry frankmcsherry requested a review from a team as a code owner December 4, 2024 13:43
Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. (I think there was even a discussion on the original Analysis framework PR to do this refactoring at some point.)

@frankmcsherry
Copy link
Contributor Author

There may well have been a discussion, and I should have called out that I didn't invent this idea, I stole it from someone!

@frankmcsherry frankmcsherry merged commit 94356ef into MaterializeInc:main Dec 4, 2024
79 checks passed
@def- def- mentioned this pull request Dec 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants