Move analysis panics into Derived*
#30634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our analysis framework allows you to build on various other analyses, but to access them you need to probe the collection to get the results, and .. potentially they might not exist (due to a logic bug). There is nothing to do other than panic, and all the "user" code immediately panics with the same messages: "Analysis FOO was required, but is missing".
This PR moves those panics into the analysis container, indicating that some methods may panic when invoked with arguments that cannot be found, not unlike array out of bounds access or key not found errors.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.