storage/postgres: Always send keepalives for the replication slot with a tokio::interval
#30631
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Makes sense to me, but I'll leave the official approval to @petrosagg.
petrosagg
approved these changes
Nov 26, 2024
petrosagg
reviewed
Nov 26, 2024
| let mut feedback_timer = tokio::time::interval(feedback_interval); | ||
| // | ||
| // Set a minimum interval to guard against feedback_interval being 0. | ||
| let minimum_interval = tokio::time::Duration::from_secs(1); |
There was a problem hiding this comment.
How can this happen? If it can indeed happen then the code below is problematic since it will be sending a keepalive back for every single message received
There was a problem hiding this comment.
(I mean the original code, not the one you added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've encountered at least one issue in local testing where the upstream Postgres DB's
wal_sender_timeoutis low enough that the timeout elapses before any of our existing inputs trigger a keepalive message to be sent.This PR adds a
tokio::Intervalto the existing loop so we can make sure we are sending a standby update/keepalive at least a healthy interval.Motivation
Fix an issue we've encountered in local testing with Neon.
Related to: https://github.com/MaterializeInc/incidents-and-escalations/issues/146
Tips for reviewer
This is my first foray into storage code! It's a relatively simple change, but there could be nuances with control flow that I'm missing
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.