Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/adapter: Introduce 'ALTER SOURCE .. REFRESH REFERENCES' statement for refreshing available upstream refs #30120

Merged
merged 2 commits into from
Oct 21, 2024
Merged

storage/adapter: Introduce 'ALTER SOURCE .. REFRESH REFERENCES' statement for refreshing available upstream refs #30120

merged 2 commits into from
Oct 21, 2024

Conversation

rjobanp
Copy link
Contributor

@rjobanp rjobanp commented Oct 21, 2024

Motivation

Also replaces #29923

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@rjobanp rjobanp requested a review from benesch October 21, 2024 17:22
@rjobanp rjobanp requested a review from a team as a code owner October 21, 2024 17:22
@rjobanp rjobanp requested a review from jkosh44 October 21, 2024 17:22
@rjobanp
Copy link
Contributor Author

rjobanp commented Oct 21, 2024

cc @bobbyiliev we've decided to change the statement to this one

@rjobanp rjobanp force-pushed the alter-source-refresh-references branch from 628af6e to dc664fa Compare October 21, 2024 17:36
jkosh44
jkosh44 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/sql-parser/src/parser.rs Show resolved Hide resolved
@rjobanp rjobanp force-pushed the alter-source-refresh-references branch from dc664fa to 518a131 Compare October 21, 2024 18:50
@rjobanp rjobanp enabled auto-merge October 21, 2024 18:50
@rjobanp rjobanp merged commit 151e00e into MaterializeInc:main Oct 21, 2024
79 checks passed
@rjobanp rjobanp deleted the alter-source-refresh-references branch October 21, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkosh44 jkosh44 jkosh44 approved these changes

@benesch benesch Awaiting requested review from benesch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjobanp @jkosh44