storage/adapter: Add source-id column to mz_catalog.mz_tables and add tables-from-sources to mz_internal source-reference tables #29374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjobanp
commented
Sep 4, 2024
Comment on lines
-479
to
-480
| let mut updates = | ||
| match entry.item() { |
There was a problem hiding this comment.
this diff is big since it the indentation wasn't correctly formatted and now it's outdented the whole match statement, but the only update I made was within the CatalogItem::Table(table) case of the match
There was a problem hiding this comment.
Suppressing whitespace works perfectly here (https://github.com/MaterializeInc/materialize/pull/29374/files?w=1)—thanks for the callout!
rjobanp
force-pushed
the
mz-tables-sources
branch
2 times, most recently
from
7c384e1 to
bcfd432
Compare
benesch
approved these changes
Sep 5, 2024
Comment on lines
-479
to
-480
| let mut updates = | ||
| match entry.item() { |
There was a problem hiding this comment.
Suppressing whitespace works perfectly here (https://github.com/MaterializeInc/materialize/pull/29374/files?w=1)—thanks for the callout!
… tables-from-sources to mz_internal source-reference tables
rjobanp
force-pushed
the
mz-tables-sources
branch
from
bcfd432 to
aac503b
Compare
jkosh44
approved these changes
Sep 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implements some of the work towards https://github.com/MaterializeInc/database-issues/issues/8511 with the goal of unblocking @bobbyiliev 's work on the terraform provider (MaterializeInc/terraform-provider-materialize#645)
The introspection updates are described in the design doc PR #27907 - see here for rendered form: https://github.com/rjobanp/materialize/blob/subsource-deprecation-blue-green/doc/developer/design/20240625_source_versioning__table_from_sources.md#system-catalog--introspection-updates
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.