Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: retain history #24368

Closed

Conversation

nrainer-materialize
Copy link
Contributor

@nrainer-materialize nrainer-materialize commented Jan 11, 2024

Note that this does not match all occurrences (e.g., ones with early line breaks) but it should be sufficient to catch a good amount.

Replacing
(?<!SHOW )(CREATE MATERIALIZED VIEW (IF NOT EXISTS )?(\w+\.?\w*) WITH \()
with
$1RETAIN HISTORY FOR '30s',
in all python and td files.

Replacing
(?<!SHOW )(CREATE MATERIALIZED VIEW (IF NOT EXISTS )?(\w+\.?\w*))(( AS)?)
with
$1 WITH (RETAIN HISTORY FOR '30s')$4
in all python and td files.

Replacing (fixing)
(WITH \(RETAIN HISTORY FOR '30s'\))\s+(\([^)]+\))
with
$2 $1
in all files.

Replacing (fixing)
(WITH \(RETAIN HISTORY FOR '30s'\)) (IN CLUSTER [^ ]+)
with
$2 $1
in all files.

Replacing (fixing)
( WITH \(RETAIN HISTORY FOR '30s'\))(\{[^}]+\})
with
$2$1
in all files.

@nrainer-materialize
Copy link
Contributor Author

Identified problem: #24459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant