-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temp: retain history #24368
Closed
nrainer-materialize
wants to merge
13
commits into
MaterializeInc:main
from
nrainer-materialize:temp
Closed
temp: retain history #24368
nrainer-materialize
wants to merge
13
commits into
MaterializeInc:main
from
nrainer-materialize:temp
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrainer-materialize
force-pushed
the
temp
branch
from
January 15, 2024 13:16
124d078
to
2ecf011
Compare
nrainer-materialize
force-pushed
the
temp
branch
from
January 16, 2024 10:40
5fccb39
to
aa59b91
Compare
nrainer-materialize
force-pushed
the
temp
branch
from
January 16, 2024 12:35
aa59b91
to
26e4c44
Compare
Identified problem: #24459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this does not match all occurrences (e.g., ones with early line breaks) but it should be sufficient to catch a good amount.
Replacing
(?<!SHOW )(CREATE MATERIALIZED VIEW (IF NOT EXISTS )?(\w+\.?\w*) WITH \()
with
$1RETAIN HISTORY FOR '30s',
in all python and td files.
Replacing
(?<!SHOW )(CREATE MATERIALIZED VIEW (IF NOT EXISTS )?(\w+\.?\w*))(( AS)?)
with
$1 WITH (RETAIN HISTORY FOR '30s')$4
in all python and td files.
Replacing (fixing)
(WITH \(RETAIN HISTORY FOR '30s'\))\s+(\([^)]+\))
with
$2 $1
in all files.
Replacing (fixing)
(WITH \(RETAIN HISTORY FOR '30s'\)) (IN CLUSTER [^ ]+)
with
$2 $1
in all files.
Replacing (fixing)
( WITH \(RETAIN HISTORY FOR '30s'\))(\{[^}]+\})
with
$2$1
in all files.