Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Fix testdrive test to not overwrite schema #22054

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

moulimukherjee
Copy link
Contributor

@moulimukherjee moulimukherjee commented Sep 28, 2023

This is correcting a testdrive test which inadvertently worked.

So, apparently it's possible to create multiple sinks on the same kafka topic and we just publish a new avro schema? I guess we missed the test was using the same topic to publish different schema and the overwrite wasn't taking long. With some refactoring in #21852, the CI started continuously failing https://buildkite.com/materialize/tests/builds/64722#018add21-f1a5-4258-bf3a-01148d0e33a6.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@sploiselle sploiselle enabled auto-merge (rebase) September 28, 2023 22:36
@sploiselle sploiselle merged commit bff24d4 into MaterializeInc:main Sep 28, 2023
@moulimukherjee moulimukherjee deleted the fix-defaults-test branch October 2, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants