Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixing nightlies for temporal precision tests #21895

Closed
wants to merge 1 commit into from
Closed

test: fixing nightlies for temporal precision tests #21895

wants to merge 1 commit into from

Conversation

moulimukherjee
Copy link
Contributor

@moulimukherjee moulimukherjee commented Sep 22, 2023 •
edited
Loading

Temporal with precision did not go out in 0.69, changing the version number in upgrade test.

Motivation

Fixing broken nightlies https://buildkite.com/materialize/nightlies/builds/4217, saw in #21842

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@moulimukherjee moulimukherjee changed the title test: temporal with precision did not go out in 0.69 test: fixing nightlies for temporal precision tests Sep 22, 2023
@moulimukherjee moulimukherjee mentioned this pull request Sep 22, 2023
Merged
5 tasks
def-
def- reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #21886

@moulimukherjee
Copy link
Contributor Author

Awesome, closing this 👍

@moulimukherjee moulimukherjee deleted the fix-nightly branch September 22, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@def- def- def- left review comments

@sploiselle sploiselle Awaiting requested review from sploiselle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moulimukherjee @def-