update clap and fix 1.69 clippy lints #18992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrodriguez-m
approved these changes
Apr 27, 2023
benesch
approved these changes
Apr 27, 2023
|
This ended up causing a bunch of duplicate deps that I had to allow, so it will need another look! |
benesch
approved these changes
Apr 27, 2023
Comment on lines
+22
to
+35
| { name = "windows-sys", version = "0.45.0" }, | ||
| { name = "windows-targets", version = "0.42.0" }, | ||
| { name = "windows_aarch64_gnullvm", version = "0.42.0" }, | ||
| { name = "windows_aarch64_msvc", version = "0.42.0" }, | ||
| { name = "windows_i686_gnu", version = "0.42.0" }, | ||
| { name = "windows_i686_msvc", version = "0.42.0" }, | ||
| { name = "windows_x86_64_gnullvm", version = "0.42.0" }, | ||
| { name = "windows_x86_64_gnu", version = "0.42.0" }, | ||
| { name = "windows_x86_64_msvc", version = "0.42.0" }, | ||
| # Newer versions of crates like `tempfile` are held back by crates like `atty`. | ||
| # This is very Unfortunate as we don't actually use these platforms. | ||
| { name = "hermit-abi", version = "0.1.6" }, | ||
| { name = "hermit-abi", version = "0.2.6" }, | ||
| { name = "redox_syscall", version = "0.2.10" }, |
There was a problem hiding this comment.
Oooof. I'm okay with this if you are willing to be on the hook for wrangling all these duplicate deps over time. (Periodically chasing new versions and sending dependency bump PRs around.)
There was a problem hiding this comment.
Yeah I can do that!
There was a problem hiding this comment.
I'm also happy to help as I find myself wrangling many of these duplicates in the cloud repo too :-(
necaris
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clap v3 is going to be quite annoying going forward. It produces clippy lints that must be allowed at a module-level, which means introducing a new module. This can be cleaned up when: clap-rs/clap#4857 (comment) is resolved!
Other lints in 1.69 that came up weren't bad!
Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.