Skip to content

Commit

Permalink
respond to GitHub feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
ParkMyCar committed Dec 5, 2024
1 parent 4a31692 commit 02b0137
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/catalog/src/memory/objects.rs
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ impl From<CatalogEntry> for durable::Item {
pub struct Table {
/// Parse-able SQL that defines this table.
pub create_sql: Option<String>,
/// [`RelationDesc`] of this table, derived from the `create_sql`.
/// [`VersionedRelationDesc`] of this table, derived from the `create_sql`.
pub desc: VersionedRelationDesc,
/// Versions of this table, and the [`GlobalId`]s that refer to them.
#[serde(serialize_with = "mz_ore::serde::map_key_to_string")]
Expand Down
3 changes: 3 additions & 0 deletions src/sql/src/plan/statement/ddl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,9 @@ pub fn plan_create_table(
let names: Vec<_> = columns
.iter()
.filter(|c| {
// This set of `names` is used to create the initial RelationDesc.
// Columns that have been added at later versions of the table will
// get added further below.
let is_versioned = c
.options
.iter()
Expand Down

0 comments on commit 02b0137

Please sign in to comment.