Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove finalizer cleanup code #470

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

alex-hunt-materialize
Copy link
Collaborator

Removes finalizer cleanup code. It was only needed to remove finalizers added by older versions.
Updates README.md to remove unnecessary ENV vars.

@alex-hunt-materialize alex-hunt-materialize force-pushed the remove_finalizer_cleanup_code branch 2 times, most recently from bdf4118 to 7fd62c7 Compare June 24, 2024 17:38
@alex-hunt-materialize
Copy link
Collaborator Author

This is ready for review, but is based on #471 so may need a no-op rebase after that goes in.

@alex-hunt-materialize alex-hunt-materialize marked this pull request as ready for review June 24, 2024 17:53
@alex-hunt-materialize alex-hunt-materialize requested a review from a team as a code owner June 24, 2024 17:53
@alex-hunt-materialize alex-hunt-materialize force-pushed the remove_finalizer_cleanup_code branch from 7fd62c7 to 21b3d7a Compare June 24, 2024 18:34
Copy link
Contributor

@jubrad jubrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@alex-hunt-materialize alex-hunt-materialize merged commit e8faa33 into main Jun 24, 2024
3 checks passed
@alex-hunt-materialize alex-hunt-materialize deleted the remove_finalizer_cleanup_code branch June 24, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants