Move k8s-openapi to dev dependency #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-hunt-materialize
force-pushed
the
move_k8s-openapi_to_dev_dependency
branch
from
eadea68 to
fab8038
Compare
|
do we even need it to be a dev dependency? |
It is required for the tests, and is the recommended way to handle this in the "no version feature is enabled" error message. |
|
ah, i missed that we had tests, makes sense |
doy-materialize
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move k8s-openapi to dev dependency, so we don't have to bump the feature every time we bump a binary crate using it. This will also allow other people to use it besides just us, without forcing them to upgrade kubernetes in lockstep with us.