Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutual TLS authentication support #86

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Add mutual TLS authentication support #86

merged 1 commit into from
Mar 22, 2023

Conversation

bobbyiliev
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

Adding support for mutual TLS authentication.

The user needs to set the following env vars:

# For Kafka SSL Authentication:
SSL_CA_LOCATION=
SSL_CERT_LOCATION=
SSL_KEY_LOCATION=

We will have the following precedence:

  • If SASL env details are set, we will default to that
  • Next in order will be TLS details
  • Finally, if none are set we will default to no auth, eg. locally running Kafka

Related Tickets & Documents

Closes #69

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Contributor

@sjwiesman sjwiesman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 assuming you've used

@bobbyiliev bobbyiliev merged commit 7441dc3 into main Mar 22, 2023
@bobbyiliev bobbyiliev deleted the kafka-tls-auth branch March 22, 2023 09:32
recursethis pushed a commit to recursethis/materialize-datagen that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Enable client authentication with TLS for Kafka connections
2 participants